Add tests and implement boundary smoothing and cutout functionality
- Introduced tests for boundary smoothing in `test_boundary_smoothing.py`, verifying that smoothing reduces stair-step artifacts while preserving boundary integrity. - Added tests for cutout boundary behavior in `test_cutout_boundary.py`, ensuring proper handling of boundary triangles and normal blending. - Created `test_temporary_attributes.py` to check the cleanup of temporary attributes across depth modifier branches, ensuring no warnings are raised. - Implemented point culling functionality in `test_validity.py`, confirming that invalid points are removed without affecting adjacent geometry. - Developed boundary smoothing logic in `boundary_smoothing.py`, allowing for depth smoothing while maintaining edge integrity. - Added cutout boundary management in `cutout_boundary.py`, including functions for removing boundary triangles and tapering thickness profiles. - Implemented validity checks in `validity.py` to ensure proper deletion of invalid vertices and associated wire edges.
This commit is contained in:
@@ -50,9 +50,9 @@ class AiSetupTest(BlenderTestCase):
|
||||
with self.assertRaisesRegex(
|
||||
RuntimeError,
|
||||
(
|
||||
"Fast \\| MoGe-2 ViT-S Normal: network unavailable; "
|
||||
"Fast \\| BiRefNet Lite: network unavailable; "
|
||||
"Fast \\| Real-ESRGAN General WDN x4v3: network unavailable"
|
||||
"MoGe-2 ViT-S Normal: network unavailable; "
|
||||
"BiRefNet Lite: network unavailable; "
|
||||
"Real-ESRGAN General WDN x4v3: network unavailable"
|
||||
),
|
||||
):
|
||||
self.runtime.post_install(SimpleNamespace(request=request))
|
||||
|
||||
37
tests/anyimage/operators/test_brush_preview_integration.py
Normal file
37
tests/anyimage/operators/test_brush_preview_integration.py
Normal file
@@ -0,0 +1,37 @@
|
||||
import bpy
|
||||
import numpy as np
|
||||
|
||||
from anyimage.operators.clipboard_image.actions import _set_brush_preview
|
||||
|
||||
|
||||
def test_packed_brush_preview_preserves_image_and_survives_reopen(tmp_path):
|
||||
bpy.ops.wm.read_factory_settings(use_empty=True)
|
||||
image = bpy.data.images.new("Preview Source", width=80, height=40, alpha=True)
|
||||
pixels = np.zeros((40, 80, 4), dtype=np.float32)
|
||||
pixels[:, :40] = (1.0, 0.0, 0.0, 1.0)
|
||||
image.pixels.foreach_set(pixels.ravel())
|
||||
image.pack()
|
||||
original_pixels = tuple(image.pixels)
|
||||
original_format = image.file_format
|
||||
brush = bpy.data.brushes.new("Preview Brush", mode="TEXTURE_PAINT")
|
||||
brush.asset_mark()
|
||||
try:
|
||||
_set_brush_preview(bpy.context, brush, image)
|
||||
assert tuple(brush.preview.image_size) == (80, 40)
|
||||
preview = np.array(brush.preview.image_pixels_float[:]).reshape(40, 80, 4)
|
||||
assert np.allclose(preview[:, :40, 0], 1.0, atol=1 / 255)
|
||||
assert np.all(preview[:, :40, 3] == 1.0)
|
||||
assert np.all(preview[:, 40:, 3] == 0.0)
|
||||
assert tuple(image.pixels) == original_pixels
|
||||
assert tuple(image.size) == (80, 40)
|
||||
assert image.packed_file is not None
|
||||
assert image.file_format == original_format
|
||||
expected_preview = tuple(brush.preview.image_pixels)
|
||||
path = str(tmp_path / "brush-preview.blend")
|
||||
bpy.ops.wm.save_as_mainfile(filepath=path)
|
||||
bpy.ops.wm.open_mainfile(filepath=path)
|
||||
restored = bpy.data.brushes["Preview Brush"]
|
||||
assert tuple(restored.preview.image_size) == (80, 40)
|
||||
assert tuple(restored.preview.image_pixels) == expected_preview
|
||||
finally:
|
||||
bpy.ops.wm.read_factory_settings(use_empty=True)
|
||||
@@ -631,6 +631,89 @@ class ClipboardImageTest(unittest.TestCase):
|
||||
self.assertEqual(brush.texture_slot.map_mode, "STENCIL")
|
||||
self.assertEqual(brush.stencil_dimension, (256.0, 144.0))
|
||||
|
||||
def test_brush_preview_updates_local_copy_only_in_texture_paint(self):
|
||||
for mode in ("PAINT_TEXTURE", "SCULPT", "PAINT_VERTEX"):
|
||||
with self.subTest(mode=mode):
|
||||
brush = SimpleNamespace(
|
||||
texture=None,
|
||||
texture_slot=SimpleNamespace(texture=None),
|
||||
stencil_dimension=(256.0, 256.0),
|
||||
update_tag=Mock(),
|
||||
)
|
||||
context = SimpleNamespace(mode=mode, brush=object())
|
||||
images = [SimpleNamespace(name=name, size=(80, 40)) for name in ("A", "B")]
|
||||
textures = FakeTextures()
|
||||
with (
|
||||
patch.object(self.actions.bpy, "data", SimpleNamespace(textures=textures)),
|
||||
patch.object(self.actions, "_ensure_editable_brush", return_value=brush),
|
||||
patch.object(self.actions, "_set_brush_preview") as preview,
|
||||
):
|
||||
for image in images:
|
||||
self.actions.set_tool_texture(context, image)
|
||||
self.assertIs(brush.texture.image, images[-1])
|
||||
self.assertEqual(preview.call_count, 2 if mode == "PAINT_TEXTURE" else 0)
|
||||
if mode == "PAINT_TEXTURE":
|
||||
self.assertEqual([call.args[1:] for call in preview.call_args_list],
|
||||
[(brush, image) for image in images])
|
||||
|
||||
def test_brush_preview_cleans_export_on_success_cancel_and_error(self):
|
||||
for outcome in ({"FINISHED"}, {"CANCELLED"}, RuntimeError("preview failed")):
|
||||
with self.subTest(outcome=outcome):
|
||||
brush, image = object(), object()
|
||||
context = SimpleNamespace(scene=object(), temp_override=Mock(return_value=nullcontext()))
|
||||
loader = Mock()
|
||||
if isinstance(outcome, Exception):
|
||||
loader.side_effect = outcome
|
||||
else:
|
||||
loader.return_value = outcome
|
||||
with (
|
||||
patch.object(self.actions, "save_packed_image", return_value="preview.png"),
|
||||
patch.object(self.actions, "cleanup_image_input") as cleanup,
|
||||
patch.object(self.actions.bpy, "ops", SimpleNamespace(
|
||||
ed=SimpleNamespace(lib_id_load_custom_preview=loader)), create=True),
|
||||
):
|
||||
expectation = nullcontext() if outcome == {"FINISHED"} else self.assertRaises(self.actions.BrushPreviewError)
|
||||
with expectation:
|
||||
self.actions._set_brush_preview(context, brush, image)
|
||||
cleanup.assert_called_once_with("preview.png", True)
|
||||
context.temp_override.assert_called_once_with(id=brush)
|
||||
loader.assert_called_once_with(filepath="preview.png")
|
||||
|
||||
def test_preview_failure_preserves_texture_and_redraws(self):
|
||||
textures = FakeTextures()
|
||||
brush = SimpleNamespace(
|
||||
texture=None, texture_slot=SimpleNamespace(texture=None),
|
||||
stencil_dimension=(256.0, 256.0), update_tag=Mock(),
|
||||
)
|
||||
context = SimpleNamespace(mode="PAINT_TEXTURE", brush=brush, area=SimpleNamespace(tag_redraw=Mock()))
|
||||
image = SimpleNamespace(name="Clipboard", size=(80, 40))
|
||||
with (
|
||||
patch.object(self.actions.bpy, "data", SimpleNamespace(textures=textures)),
|
||||
patch.object(self.actions, "_set_brush_preview", side_effect=self.actions.BrushPreviewError("preview failed")),
|
||||
self.assertRaises(self.actions.BrushPreviewError),
|
||||
):
|
||||
self.actions.set_tool_texture(context, image)
|
||||
self.assertEqual(len(textures), 1)
|
||||
self.assertIs(brush.texture.image, image)
|
||||
context.area.tag_redraw.assert_called_once()
|
||||
|
||||
def test_preview_warning_finishes_paste(self):
|
||||
module = self.addon.clipboard_image
|
||||
operator = module.PasteClipboardImage()
|
||||
operator.paste_target = "TOOL_TEXTURE"
|
||||
operator.location_set = False
|
||||
operator.import_as = "REFERENCE"
|
||||
operator.shadeless = False
|
||||
operator.report = Mock()
|
||||
with (
|
||||
patch.object(module, "_should_defer_to_native_paste", return_value=False),
|
||||
patch.object(module, "read_clipboard_image", return_value=(b"image", ".png")),
|
||||
patch.object(module, "acquire_packed_image", return_value=(object(), False)),
|
||||
patch.object(module, "paste_image", side_effect=self.actions.BrushPreviewError("preview failed")),
|
||||
):
|
||||
self.assertEqual(operator.execute(SimpleNamespace()), {"FINISHED"})
|
||||
operator.report.assert_called_once_with({"WARNING"}, "preview failed")
|
||||
|
||||
def test_localizes_read_only_active_brush(self):
|
||||
local_brush = SimpleNamespace(is_editable=True, library=None)
|
||||
linked_brush = SimpleNamespace(
|
||||
|
||||
@@ -26,6 +26,17 @@ def test_new_cutout_does_not_reuse_a_saved_wrapper():
|
||||
assert any(item.name == "Shape" for item in saved.interface.items_tree)
|
||||
|
||||
|
||||
def test_depth_cutout_loads_boundary_blur_revision_and_preserves_existing_group():
|
||||
bpy.ops.wm.read_factory_settings(use_empty=True)
|
||||
saved = bpy.data.node_groups.new("O Image Depth Cutout", "GeometryNodeTree")
|
||||
saved["anyimage_asset_revision"] = 11
|
||||
current = load_cutout_node_group("DEPTH_SOLID")
|
||||
assert current != saved and current["anyimage_asset_revision"] == 18
|
||||
assert saved in bpy.data.node_groups.values()
|
||||
assert saved["anyimage_asset_revision"] == 11
|
||||
assert load_cutout_node_group("DEPTH_SOLID") == current
|
||||
|
||||
|
||||
def test_refined_boundary_ears_have_interior_balloon_samples():
|
||||
points = np.array([(0, 0), (1, 0), (1, 1), (0, 1)], dtype=float)
|
||||
points, faces, boundary = refine_balloon_triangles(points, [(0, 1, 2), (0, 2, 3)], np.ones(4, bool))
|
||||
|
||||
@@ -46,7 +46,8 @@ def test_cutout_node_groups_are_loaded_from_the_asset():
|
||||
) as load:
|
||||
for shape in cutout_shape.CUTOUT_NODE_GROUP_NAMES:
|
||||
assert cutout_object.load_cutout_node_group(shape) is loaded
|
||||
load.assert_called_with(cutout_shape.CUTOUT_NODE_GROUP_NAMES[shape], asset_revision=11)
|
||||
load.assert_called_with(cutout_shape.CUTOUT_NODE_GROUP_NAMES[shape],
|
||||
asset_revision=18 if shape == "DEPTH_SOLID" else 11)
|
||||
assert load.call_count == 4
|
||||
|
||||
|
||||
|
||||
@@ -187,7 +187,11 @@ def test_cutout_presets_load_three_direct_modifier_assets():
|
||||
assert inputs["Mode"].default_value == "Balloon"
|
||||
assert inputs["Smooth"].default_value == 0
|
||||
assert inputs["Smooth Weight"].default_value == 1
|
||||
assert "Edge Smooth" not in inputs
|
||||
if shape == "DEPTH_SOLID":
|
||||
assert inputs["Boundary Smooth"].default_value == 5
|
||||
assert inputs["Boundary Smooth"].parent.name == "Options"
|
||||
else:
|
||||
assert "Boundary Smooth" not in inputs
|
||||
assert not any(node.bl_idname == "GeometryNodeRepeatInput" and node.inputs["Iterations"].default_value == 8 for node in group.nodes)
|
||||
assert next(item for item in groups["DEPTH_BALLOON"].interface.items_tree if item.name == "Double Sided").default_value
|
||||
|
||||
@@ -424,17 +428,17 @@ def test_depth_surface_keeps_continuous_points_across_zero_validity_edge():
|
||||
assert np.ptp(positions[:, 2]) < 1e-4
|
||||
|
||||
|
||||
def test_depth_surface_split_removes_isolated_triangle_without_loose_geometry():
|
||||
def test_depth_surface_removes_boundary_ears_without_loose_geometry():
|
||||
bpy.ops.wm.read_factory_settings(use_empty=True)
|
||||
obj, modifier = _depth_surface_step_object()
|
||||
split_id = object_data.modifier_input_identifier(modifier.node_group, "Split Threshold")
|
||||
# The raised corner becomes an isolated triangle after separation.
|
||||
for value, expected in ((0., (9, 8)), (.5, (8, 7)), (1., (8, 7))):
|
||||
# Both outer ears have three boundary vertices, including the raised corner.
|
||||
for value in (0., .5, 1.):
|
||||
object_data.set_modifier_input(modifier, split_id, value)
|
||||
obj.update_tag(refresh={"DATA"})
|
||||
bpy.context.view_layer.update()
|
||||
vertices, faces, loose_edges, loose_points = _evaluated_topology(obj)
|
||||
assert (vertices, faces) == expected
|
||||
assert (vertices, faces) == (7, 6)
|
||||
assert not loose_edges and not loose_points
|
||||
|
||||
|
||||
|
||||
@@ -81,12 +81,17 @@ def artifacts(tmp_path, source):
|
||||
|
||||
def test_result_replaces_source_with_zero_rotation_and_shadeless_material(source, artifacts, monkeypatch):
|
||||
result, operator = artifacts
|
||||
saved = bpy.data.node_groups.new("O Image Depth Panorama", "GeometryNodeTree")
|
||||
saved["anyimage_asset_revision"] = 11
|
||||
matrix = Matrix.Translation((2, -3, 4)) @ Matrix.Rotation(0.6, 4, "Y") @ Matrix.Diagonal((2, 3, 4, 1))
|
||||
source.matrix_world = matrix
|
||||
source.empty_image_offset = (0.3, -0.8)
|
||||
undo = Mock(return_value={"FINISHED"})
|
||||
monkeypatch.setattr(conversion, "bpy", SimpleNamespace(data=bpy.data, ops=SimpleNamespace(ed=SimpleNamespace(undo_push=undo))))
|
||||
obj = conversion.create_panorama_from_result(bpy.context, result, operator)
|
||||
assert obj.modifiers[0].node_group != saved
|
||||
assert obj.modifiers[0].node_group["anyimage_asset_revision"] == 14
|
||||
assert saved in bpy.data.node_groups.values() and saved["anyimage_asset_revision"] == 11
|
||||
assert obj.name == operator.source_object_name and obj.type == "MESH"
|
||||
np.testing.assert_allclose(obj.location, matrix.translation, atol=1e-6)
|
||||
np.testing.assert_allclose(obj.scale, matrix.to_scale(), atol=1e-6)
|
||||
|
||||
@@ -11,7 +11,7 @@ def test_conversion_preserves_offset_world_placement_and_initializes_inputs(surf
|
||||
|
||||
obj, _, _, inputs, image = surface
|
||||
group = obj.modifiers[0].node_group
|
||||
monkeypatch.setattr(conversion, "load_node_group", lambda name: group)
|
||||
monkeypatch.setattr(conversion, "load_node_group", lambda name, *, asset_revision: group)
|
||||
source = bpy.data.objects.new("Offset Image", None)
|
||||
source.empty_display_type = "IMAGE"
|
||||
source.data = image
|
||||
@@ -48,7 +48,7 @@ def test_failed_modifier_initialization_removes_partial_object(surface, monkeypa
|
||||
from anyimage.operators.convert_to_plane import object as conversion
|
||||
|
||||
obj, _, _, _, image = surface
|
||||
monkeypatch.setattr(conversion, "load_node_group", lambda name: obj.modifiers[0].node_group)
|
||||
monkeypatch.setattr(conversion, "load_node_group", lambda name, *, asset_revision: obj.modifiers[0].node_group)
|
||||
source = bpy.data.objects.new("Source", None)
|
||||
source.empty_display_type = "IMAGE"
|
||||
source.data = image
|
||||
|
||||
@@ -73,7 +73,8 @@ def test_clipboard_plane_uses_the_mesh_material_slot():
|
||||
|
||||
def test_converted_planes_center_the_origin_without_moving_world_corners():
|
||||
bpy.ops.wm.read_factory_settings(use_empty=True)
|
||||
build_image_depth_plane_group(build_image_plane_group())
|
||||
saved = build_image_depth_plane_group(build_image_plane_group())
|
||||
saved["anyimage_asset_revision"] = 11
|
||||
|
||||
def create_source(name):
|
||||
image = bpy.data.images.new(name, width=200, height=100)
|
||||
@@ -149,6 +150,9 @@ def test_converted_planes_center_the_origin_without_moving_world_corners():
|
||||
assert_centered(depth_plane, depth_bounds, depth_matrix)
|
||||
assert depth_plane["anyimage_mesh_shape"] == "DEPTH_PLANE"
|
||||
depth_modifier = depth_plane.modifiers[0]
|
||||
assert depth_modifier.node_group != saved
|
||||
assert depth_modifier.node_group["anyimage_asset_revision"] == 14
|
||||
assert saved in bpy.data.node_groups.values() and saved["anyimage_asset_revision"] == 11
|
||||
uniform_scale = depth_modifier[
|
||||
object_data.modifier_input_identifier(
|
||||
depth_modifier.node_group,
|
||||
|
||||
Reference in New Issue
Block a user